bpo-46025: Fix a crash in the atexit module for auto-unregistering functions #30002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Dec 9, 2021
tiran
reviewed
Dec 9, 2021
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Christian Heimes <[email protected]>
vstinner
approved these changes
Dec 9, 2021
| atexit._run_exitfuncs() | ||
| self.assertEqual(cm.unraisable.object, func) | ||
| self.assertEqual(cm.unraisable.exc_type, ZeroDivisionError) | ||
| self.assertEqual(type(cm.unraisable.exc_value), ZeroDivisionError) |
There was a problem hiding this comment.
Not sure if checking exc_value is needed, but it's ok to test it :-)
There was a problem hiding this comment.
This makes it a military-grade test :)
|
@pablogsal: Status check is done, and it's a failure ❌ . |
1 similar comment
|
@pablogsal: Status check is done, and it's a failure ❌ . |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-30005 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 9, 2021
…nctions (pythonGH-30002) (cherry picked from commit f0d290d) Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal
added a commit
that referenced
this pull request
Dec 9, 2021
…nctions (GH-30002) (GH-30005) (cherry picked from commit f0d290d) Co-authored-by: Pablo Galindo Salgado <[email protected]> Co-authored-by: Pablo Galindo Salgado <[email protected]>
|
Thanks for the fix ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46025