-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Fix broken OMG link #30383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken OMG link #30383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The old link does work for me (macOS/Chrome) and it downloads this file:
But if it's not working for others, then it should be replaced. It's also http not https.
Here's the document at the new link, an added benefit is it opens in the browser rather than downloading to disk.
I can confirm they're identical binary files:
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The old url works for me, though it downloads the file, whereas the new link opens in the browser. I think opening the file in the browser is better.
Thanks @davidgilbertson for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
(cherry picked from commit 04215a4) Co-authored-by: David Gilbertson <[email protected]>
GH-31342 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit 04215a4) Co-authored-by: David Gilbertson <[email protected]>
GH-31343 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit 04215a4) Co-authored-by: David Gilbertson <[email protected]>
(cherry picked from commit 04215a4) Co-authored-by: David Gilbertson <[email protected]> Co-authored-by: David Gilbertson <[email protected]>
(cherry picked from commit 04215a4) Co-authored-by: David Gilbertson <[email protected]>
I got the new link from this page: https://www.omg.org/spec/PYTH
I'm not certain that it's the right doc, but the dates and title match.