Skip to content

bpo-46249: Move set lastrowid out of the sqlite3 query loop #30489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2022
Merged

bpo-46249: Move set lastrowid out of the sqlite3 query loop #30489

merged 1 commit into from
Jan 22, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 8, 2022 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

(GitHub would not let me resurrect GH-30371 because I deleted the original branch.)

@erlend-aasland
Copy link
Contributor Author

Skipping news as it is an internal change only. No user visible effects.

@erlend-aasland erlend-aasland changed the title bpo-46249: Move set lastrowid out of the sqlite3 query loop bpo-46249: Move set lastrowid out of the sqlite3 query loop Jan 8, 2022
@erlend-aasland erlend-aasland changed the title bpo-46249: Move set lastrowid out of the sqlite3 query loop bpo-46249: Move set lastrowid out of the sqlite3 query loop Jan 8, 2022
@felixxm
Copy link
Contributor

felixxm commented Jan 12, 2022

I confirmed this doesn't break anything in Django tests ✔️

corona10
corona10 approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked closely at the change, but it doesn't seem like a regression will happen.
LGTM

@corona10 corona10 merged commit 38afeb1 into python:main Jan 22, 2022
@erlend-aasland erlend-aasland deleted the sqlite-optimise-query-loop/last-row-id branch January 22, 2022 11:23
@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing, Dong-hee!

@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@malemburg malemburg Awaiting requested review from malemburg

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @felixxm @corona10 @the-knights-who-say-ni @bedevere-bot