Skip to content

bpo-46359: continue to modernize test_typing #30563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2022
Merged

bpo-46359: continue to modernize test_typing #30563

merged 1 commit into from
Jan 13, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 12, 2022 •
edited by bedevere-bot
Loading

This is a follow up to #30547

CC @corona10 as my mentor.

https://bugs.python.org/issue46359

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 12, 2022
@gvanrossum
Copy link
Member

I'm sorry, I'm overwhelmed, hopefully @corona10 can review and merge.

@corona10 corona10 self-requested a review January 13, 2022 00:07
hugovk
hugovk approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, removes irrelevant checks for EOL Python versions and deletes an unused test for <3.6.

Fidget-Spinner
Fidget-Spinner approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. These are probably artefacts from back when typing was still a separate library on pypi.

@Fidget-Spinner Fidget-Spinner merged commit 8c49d05 into python:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@corona10 corona10 Awaiting requested review from corona10

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sobolevn @gvanrossum @hugovk @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot