Skip to content

Update html.parser.rst #30678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Update html.parser.rst #30678

merged 3 commits into from
Feb 17, 2022

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Jan 18, 2022

This PR for the documentation of the html.parser module will

  • fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
  • mention the parameter names of the HTMLParser.handle_* methods where missing.

Automerge-Triggered-By: GH:merwok

@geryogam geryogam requested a review from merwok February 11, 2022 16:03
@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-31385 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2022
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)

Co-authored-by: Géry Ogam <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 17, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2022
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)

Co-authored-by: Géry Ogam <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 17, 2022
@bedevere-bot
Copy link

GH-31386 is a backport of this pull request to the 3.9 branch.

@merwok
Copy link
Member

merwok commented Feb 17, 2022

I should have changed the PR title to get a better commit message, like «Improve wording in html.parser doc»

«update file x» is not very useful, we try to always explain what is done (and often why too).

miss-islington added a commit that referenced this pull request Feb 17, 2022
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)


Co-authored-by: Géry Ogam <[email protected]>

Automerge-Triggered-By: GH:merwok
miss-islington added a commit that referenced this pull request Feb 17, 2022
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)

Co-authored-by: Géry Ogam <[email protected]>
@geryogam geryogam deleted the patch-6 branch February 17, 2022 15:12
@geryogam
Copy link
Contributor Author

geryogam commented Feb 17, 2022

Thanks for the review @merwok and @JelleZijlstra. Next time I will choose a better PR title than the default one.

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)

Co-authored-by: Géry Ogam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants