bpo-46483: change PurePath.__class_getitem__ to return GenericAlias
#30822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
commented
Jan 23, 2022
| @@ -2429,13 +2429,19 @@ def test_complex_symlinks_relative(self): | |||
| def test_complex_symlinks_relative_dot_dot(self): | |||
| self._check_complex_symlinks(os.path.join('dirA', '..')) | |||
|
|
|||
| def test_class_getitem(self): | |||
There was a problem hiding this comment.
This test now works for all _BasePathTest subclasses, previously it was only checking PurePath.
kumaraditya303
approved these changes
Jan 23, 2022
|
@kumaraditya303 thanks for the review and for the idea 😉 |
JelleZijlstra
approved these changes
Jan 23, 2022
isidentical
approved these changes
Jan 23, 2022
|
Thanks @sobolevn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
CC @corona10 as my mentor.
https://bugs.python.org/issue46483