bpo-46484:Add test for Calendar.iterweekdays #30825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
reviewed
Mar 22, 2022
Misc/NEWS.d/next/Tests/2022-01-23-18-21-30.bpo-46484.5BSQvY.rst
Outdated
Show resolved
Hide resolved
iritkatriel
reviewed
Apr 4, 2022
Lib/test/test_calendar.py
Outdated
| for firstweekday in range(7): | ||
| cal = calendar.Calendar(firstweekday) | ||
| week = list(cal.iterweekdays()) | ||
| self.assertEqual(week[0], firstweekday) | ||
| self.assertEqual(week[-1], (firstweekday - 1) % 7) | ||
| self.assertEqual(week, result[firstweekday]) |
There was a problem hiding this comment.
You could write this test like this:
week0 = list(range(7))
for firstweekday in range(7):
cal = calendar.Calendar(firstweekday)
week = list(cal.iterweekdays())
expected = week0[firstweekday:] + week0[:firstweekday]
self.assertEqual(week, expected)
iritkatriel
approved these changes
Apr 4, 2022
iritkatriel
added
needs backport to 3.9
|
Thanks @180909 for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
GH-32307 is a backport of this pull request to the 3.10 branch. |
bedevere-bot
removed
needs backport to 3.10
|
GH-32308 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 4, 2022
(cherry picked from commit 48269ea) Co-authored-by: 180909 <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Apr 4, 2022
(cherry picked from commit 48269ea) Co-authored-by: 180909 <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Apr 4, 2022
(cherry picked from commit 48269ea) Co-authored-by: 180909 <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
(cherry picked from commit 48269ea) Co-authored-by: 180909 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46484
https://bugs.python.org/issue46484