-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-46475: Add typing.Never and typing.assert_never #30842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
86a868f
4b227f6
403f8e5
d3cc0f5
9621493
1b297fe
02a3e89
b3f4ccb
2530bd7
c23cc26
4497a26
c731977
1f6b671
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
* Imports and exports, all public names should be explicitly added to __all__. | ||
* Internal helper functions: these should never be used in code outside this module. | ||
* _SpecialForm and its instances (special forms): | ||
Any, NoReturn, ClassVar, Union, Optional, Concatenate | ||
Any, NoReturn, Never, ClassVar, Union, Optional, Concatenate | ||
* Classes whose instances can be type arguments in addition to types: | ||
ForwardRef, TypeVar and ParamSpec | ||
* The core of internal generics API: _GenericAlias and _VariadicGenericAlias, the latter is | ||
|
@@ -117,12 +117,14 @@ def _idfunc(_, x): | |
|
||
# One-off things. | ||
'AnyStr', | ||
'assert_never', | ||
'cast', | ||
'final', | ||
'get_args', | ||
'get_origin', | ||
'get_type_hints', | ||
'is_typeddict', | ||
'Never', | ||
'NewType', | ||
'no_type_check', | ||
'no_type_check_decorator', | ||
|
@@ -173,7 +175,7 @@ def _type_check(arg, msg, is_argument=True, module=None, *, is_class=False): | |
if (isinstance(arg, _GenericAlias) and | ||
arg.__origin__ in invalid_generic_forms): | ||
raise TypeError(f"{arg} is not valid as type argument") | ||
if arg in (Any, NoReturn, Final): | ||
if arg in (Any, NoReturn, Never, Final): | ||
return arg | ||
if isinstance(arg, _SpecialForm) or arg in (Generic, Protocol): | ||
raise TypeError(f"Plain {arg} is not valid as type argument") | ||
|
@@ -441,8 +443,32 @@ def NoReturn(self, parameters): | |
def stop() -> NoReturn: | ||
raise Exception('no way') | ||
|
||
This type is invalid in other positions, e.g., ``List[NoReturn]`` | ||
will fail in static type checkers. | ||
Static type checkers treat this as a general bottom type, | ||
JelleZijlstra marked this conversation as resolved.
Show resolved
Hide resolved
|
||
a type with no members. The typing.Never type provides a | ||
more explicit name for that concept. | ||
|
||
""" | ||
raise TypeError(f"{self} is not subscriptable") | ||
|
||
@_SpecialForm | ||
def Never(self, parameters): | ||
JelleZijlstra marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"""Notation for the bottom type, a type that has no members. | ||
JelleZijlstra marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
This can be used to define a function that should never be | ||
called, or a function that never returns:: | ||
|
||
from typing import Never | ||
|
||
def never_call_me(arg: Never) -> None: | ||
pass | ||
|
||
never_call_me(1) # type checker error | ||
|
||
def stop() -> Never: | ||
return 1 # type checker error | ||
|
||
The assert_never() function uses the Never type to statically | ||
assert that code is unreachable. | ||
JelleZijlstra marked this conversation as resolved.
Show resolved
Hide resolved
|
||
""" | ||
raise TypeError(f"{self} is not subscriptable") | ||
|
||
|
@@ -1941,6 +1967,29 @@ class Film(TypedDict): | |
return isinstance(tp, _TypedDictMeta) | ||
|
||
|
||
def assert_never(arg: Never, /) -> Never: | ||
"""Statically assert that a line of code is unreachable. | ||
|
||
Example:: | ||
|
||
def int_or_str(arg: int | str) -> None: | ||
match arg: | ||
case int(): | ||
print("It's an int") | ||
case str(): | ||
print("It's a str") | ||
case _: | ||
assert_never(arg) | ||
|
||
If a type checker finds that a call to assert_never() is | ||
reachable, it will emit an error. | ||
Comment on lines
+2091
to
+2101
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This example is much better than the examples in the main doc. :-) And so is the sentence following the example. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That sentence is also in the docs for assert_never, but not Never. I'm pushing some changes to improve the Never docs according to your feedback. Honestly I'm a bit confused about the relationship between the docstring and the RST docs. I end up copying from one to the other. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Usually the docstring is shorter, since it is often displayed by tools that have limited output space (it's really annoying to get a scroll bar in a tooltip in VS Code :-). |
||
|
||
At runtime, this throws an exception when called. | ||
|
||
""" | ||
raise RuntimeError("Unreachable code") | ||
JelleZijlstra marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
def no_type_check(arg): | ||
"""Decorator to indicate that annotations are not type hints. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Add :data:`typing.Never` and :func:`typing.assert_never`. Patch by Jelle | ||
Zijlstra. |
Uh oh!
There was an error while loading. Please reload this page.