Skip to content

bpo-46522: fix concurrent.futures and io AttributeError messages #30887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/_pyio.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ def __getattr__(name):
global OpenWrapper
OpenWrapper = open
return OpenWrapper
raise AttributeError(name)
raise AttributeError(f"module {__name__!r} has no attribute {name!r}")


# In normal operation, both `UnsupportedOperation`s should be bound to the
Expand Down
2 changes: 1 addition & 1 deletion Lib/concurrent/futures/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ def __getattr__(name):
ThreadPoolExecutor = te
return te

raise AttributeError(f"module {__name__} has no attribute {name}")
raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
2 changes: 1 addition & 1 deletion Lib/io.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __getattr__(name):
global OpenWrapper
OpenWrapper = open
return OpenWrapper
raise AttributeError(name)
raise AttributeError("module {__name__!r} has no attribute {name!r}")


# Pretend this exception was created here.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make various module ``__getattr__`` AttributeErrors more closely match a typical AttributeError