Skip to content

bpo-46487: Add get_write_buffer_limits to Write and _SSLProtocol transports #30958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 1, 2022
Merged

bpo-46487: Add get_write_buffer_limits to Write and _SSLProtocol transports #30958

merged 6 commits into from
Feb 1, 2022

Conversation

mooncell07
Copy link
Contributor

@mooncell07 mooncell07 commented Jan 27, 2022 •
edited by miss-islington
Loading

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@asvetlov
Copy link
Contributor

Should wait until @pablogsal resolve issue with failed buildbots

@asvetlov asvetlov self-assigned this Jan 29, 2022
@kumaraditya303
Copy link
Contributor

The buildbots are fixed on main branch now.

@mooncell07
Copy link
Contributor Author

Um, sorry did I do something wrong

@ambv
Copy link
Contributor

ambv commented Feb 1, 2022

Nope, all good, @miss-islington went into an infinite loop applying and removing the automerge label. It took me a second to fix it, hence the temporary DO-NOT-MERGE label.

@AlexWaygood
Copy link
Member

Um, sorry did I do something wrong

I managed to trigger an anxiety attack in the miss-islington bot, because I tried to reapply the "automerge" label, to get her to merge your PR. But I'm only a CPython triager, so I don't have merge privileges, hence the anxiety attack.

Nothing to do with you — just me and the bots having a totally normal morning :) thanks @ambv for the quick fix!!

@AlexWaygood AlexWaygood mentioned this pull request Feb 1, 2022
Closed
@asvetlov asvetlov merged commit 64568ac into python:main Feb 1, 2022
@miss-islington
Copy link
Contributor

Thanks @mooncell07 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@asvetlov
Copy link
Contributor

asvetlov commented Feb 1, 2022

Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2022
@mooncell07 @miss-islington
bpo-46487: Add get_write_buffer_limits to Write and _SSLProtocol tr…
93cf59c 
…ansports (pythonGH-30958)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 64568ac)

Co-authored-by: Emiya <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 1, 2022
@bedevere-bot
Copy link

GH-31055 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2022
@mooncell07 @miss-islington
bpo-46487: Add get_write_buffer_limits to Write and _SSLProtocol tr…
cbb0be6 
…ansports (pythonGH-30958)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 64568ac)

Co-authored-by: Emiya <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 1, 2022
@bedevere-bot
Copy link

GH-31056 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Feb 1, 2022
@miss-islington @mooncell07
bpo-46487: Add get_write_buffer_limits to Write and _SSLProtocol tr…
e4a6e54 
…ansports (GH-30958)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 64568ac)

Co-authored-by: Emiya <[email protected]>
miss-islington added a commit that referenced this pull request Feb 1, 2022
@miss-islington @mooncell07
bpo-46487: Add get_write_buffer_limits to Write and _SSLProtocol tr…
e5e1441 
…ansports (GH-30958)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 64568ac)

Co-authored-by: Emiya <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @mooncell07 @hello-adam
bpo-46487: Add get_write_buffer_limits to Write and _SSLProtocol tr…
b7440ac 
…ansports (pythonGH-30958)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 64568ac)

Co-authored-by: Emiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees

@asvetlov asvetlov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mooncell07 @miss-islington @asvetlov @kumaraditya303 @AlexWaygood @ambv @bedevere-bot @the-knights-who-say-ni