bpo-46449: Fix refcount of deepfrozen code #30984
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_code() returns a borrowed reference. unmarshal_frozen_code is expected to return a strong reference. Signed-off-by: Christian Heimes <[email protected]>
tiran
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
vstinner
reviewed
Jan 28, 2022
| @@ -1321,7 +1321,7 @@ unmarshal_frozen_code(struct frozen_info *info) | |||
| if (info->get_code) { | |||
| PyObject *code = info->get_code(); | |||
| assert(code != NULL); | |||
| return code; | |||
| return Py_NewRef(code); | |||
There was a problem hiding this comment.
The get_code() function was added to the _frozen structure in Python 3.11. New C API functions must no longer return borrowed references, but strong references: https://devguide.python.org/c-api/#public-c-api
Would it be possible to change the generated code to return strong references instead? I don't understand how deepfreeze generates its "get_code()" functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_code() returns a borrowed reference. unmarshal_frozen_code is
expected to return a strong reference.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue46449