Skip to content

bpo-46407: Fix long_mod refleak #31025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jan 30, 2022

The PyLongObject from x_divrem isn't used. Introduced in f10dafc.

Before this:

python -m test test_fractions -R 3:3 -m "*FractionTest"
0:00:00 Run tests sequentially
0:00:00 [1/1] test_fractions
beginning 6 repetitions
123456
......
test_fractions leaked [23, 23, 23] references, sum=69
test_fractions leaked [23, 23, 23] memory blocks, sum=69
test_fractions failed (reference leak)

== Tests result: FAILURE ==

After:

0:00:00 Run tests sequentially
0:00:00 [1/1] test_fractions
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

https://bugs.python.org/issue46407

@Fidget-Spinner
Copy link
Member Author

CC @pablogsal this (hopefully) fixes the refleak buildbot's numerics tests. Please take a look, thank you!

@markshannon
Copy link
Member

Looks good, let's try it with the buildbots.

@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 30, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 8140e38 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 30, 2022
Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The fix looks right.

@markshannon
Copy link
Member

@pablogsal @ambv
This fixes the majority of the buildbots.
Please merge this ASAP.

@ambv ambv merged commit 7685693 into python:main Jan 31, 2022
@Fidget-Spinner Fidget-Spinner deleted the fix_long_refleak branch January 31, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants