Skip to content

[3.5] Fix broken Show Source links on documentation pages (GH-3113) #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2017

Conversation

Mariatta
Copy link
Member

The Show Source was broken because of a change made in sphinx 1.5.1
In Sphinx 1.4.9, the sourcename was "index.txt".
In Sphinx 1.5.1+, it is now "index.rst.txt".
(cherry picked from commit b9ff498)

…-3113)

The `Show Source` was broken because of a change made in sphinx 1.5.1
In Sphinx 1.4.9, the sourcename was "index.txt".
In Sphinx 1.5.1+, it is now "index.rst.txt".
(cherry picked from commit b9ff498)
@Mariatta
Copy link
Member Author

@larryhastings Show Source link on docs.python.org on the 3.5 branch is currently broken.
For example, go to: https://docs.python.org/3.5/library/index.html
and click the Show Source link on the left.

I think there are two ways to fix it, but not sure what you think:

  • accept this PR
  • rebuild the python docs using Sphinx 1.4.9

Ideas?

@Mariatta Mariatta requested a review from larryhastings August 18, 2017 03:33
@Mariatta Mariatta requested a review from ned-deily September 8, 2017 18:06
@Mariatta
Copy link
Member Author

Mariatta commented Sep 8, 2017

@larryhastings or @ned-deily can look into this?

@ned-deily ned-deily merged commit 0d68d6d into python:3.5 Sep 8, 2017
@ned-deily
Copy link
Member

Looked good to me. Thanks!

@Mariatta Mariatta deleted the backport-b9ff498-3.5 branch September 8, 2017 18:38
@Mariatta
Copy link
Member Author

Mariatta commented Sep 8, 2017

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants