bpo-46820: Fix a SyntaxError in a numeric literal followed by "not in" #31479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix parsing a numeric literal immediately (without spaces) followed by "not in" keywords, like in "1not in x". Now the parser only emits a warning, not a syntax error.
serhiy-storchaka
added
type-bug
serhiy-storchaka
requested review from
pablogsal and
lysnikolaou
as code owners
pablogsal
approved these changes
Feb 21, 2022
pablogsal
reviewed
Feb 21, 2022
| check("0not in x") | ||
| check("1.not in x") | ||
| check("1e3not in x") | ||
| check("1jnot in x") |
There was a problem hiding this comment.
Small nit: At this point maybe we want to make these strings dynamically:
for infix in ["and", "or", "in", "not in"]:
check(f"0xf{infix} x")
check(f"0o7{infix} x")
check(f"0b1{infix} x")
check(f"9{infix} x")
check(f"0{infix} x")
check(f"1.{infix} x")
check(f"1e3{infix} x")
check(f"1j{infix} x")
There was a problem hiding this comment.
I'll rewrite tests in a separate PR.
pxeger
reviewed
Feb 21, 2022
| check("0not in x") | ||
| check("1.not in x") | ||
| check("1e3not in x") | ||
| check("1jnot in x") |
There was a problem hiding this comment.
Maybe add a test with an underscore literal, just for completeness' sake?
Suggested change
| check("1jnot in x") | |
| check("1jnot in x") | |
| check("1_000not in x") |
pxeger
approved these changes
Feb 21, 2022
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-31493 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 22, 2022
pythonGH-31479) Fix parsing a numeric literal immediately (without spaces) followed by "not in" keywords, like in "1not in x". Now the parser only emits a warning, not a syntax error. (cherry picked from commit 090e5c4) Co-authored-by: Serhiy Storchaka <[email protected]>
|
xref #31494 |
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 22, 2022
GH-31479) (GH-31493) Fix parsing a numeric literal immediately (without spaces) followed by "not in" keywords, like in "1not in x". Now the parser only emits a warning, not a syntax error. (cherry picked from commit 090e5c4) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing a numeric literal immediately (without spaces) followed by
"not in" keywords, like in "1not in x". Now the parser only emits
a warning, not a syntax error.
https://bugs.python.org/issue46820