bpo-46827: pass sock.type to getaddrinfo in sock_connect #31499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update it to support UDP and TCP socket types this test was removed in python@7438792#diff-6e37e524632f0e5f40ac46ea06ed508dc3b08f9ec1e8c07cf97537913f056a6bL444-L458
asvetlov
approved these changes
Feb 22, 2022
Misc/NEWS.d/next/Library/2022-02-22-15-08-30.bpo-46827.hvj38S.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Svetlov <[email protected]>
|
@asvetlov I think this needs backporting to 3.9 and 3.10? |
graingert
commented
Feb 22, 2022
Misc/NEWS.d/next/Library/2022-02-22-15-08-30.bpo-46827.hvj38S.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Grainger <[email protected]>
|
The PR doesn't change the behavior but makes unsupported things work. |
asvetlov
added
needs backport to 3.9
|
Thanks @graingert for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
GH-31509 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 22, 2022
) Co-authored-by: Thomas Grainger <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Andrew Svetlov <[email protected]> (cherry picked from commit 8fb9489) Co-authored-by: Thomas Grainger <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 22, 2022
) Co-authored-by: Thomas Grainger <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Andrew Svetlov <[email protected]> (cherry picked from commit 8fb9489) Co-authored-by: Thomas Grainger <[email protected]>
|
GH-31510 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 22, 2022
Co-authored-by: Thomas Grainger <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Andrew Svetlov <[email protected]> (cherry picked from commit 8fb9489) Co-authored-by: Thomas Grainger <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Feb 22, 2022
Co-authored-by: Thomas Grainger <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Andrew Svetlov <[email protected]> (cherry picked from commit 8fb9489) Co-authored-by: Thomas Grainger <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
) Co-authored-by: Thomas Grainger <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Andrew Svetlov <[email protected]> (cherry picked from commit 8fb9489) Co-authored-by: Thomas Grainger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46827