bpo-46831: Update __build_class__ comment #31522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got a little bit confused by this recently. This was changed in Python 3.4 in e8e1459 and a lot of |
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
@gvanrossum planning to merge this change (fixing a confusing comment in C code for __build_class__)
JelleZijlstra
added
needs backport to 3.9
|
Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
@JelleZijlstra: Please replace |
|
GH-31652 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 81d968b) Co-authored-by: Shantanu <[email protected]>
|
GH-31653 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 81d968b) Co-authored-by: Shantanu <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 3, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 81d968b) Co-authored-by: Shantanu <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 3, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 81d968b) Co-authored-by: Shantanu <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 81d968b) Co-authored-by: Shantanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46831