[3.6] bpo-28667: Fix a compile warning on FreeBSD when compare with FD_SETSIZE. (GH-501) #3190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't backport this change because compiler warnings usually are fixed only in develop branch. |
|
Oh, these ones seem to be straighforward. It seems like there are the only warnings on FreeBSD on Python 3.6. |
|
I'd be +1 on making the build warning clean if these are the only changes required. But Serhiy is right, it's @ned-deily's call now :) |
ned-deily
approved these changes
Aug 22, 2017
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD is the only platforms with unsigned FD_SETSIZE.
(cherry picked from commit 783d0c1)
https://bugs.python.org/issue28667