bpo-47088: Add typing.LiteralString (PEP 675) #32064
Conversation
JelleZijlstra
requested review from
gvanrossum and
Fidget-Spinner
as code owners
Co-authored-by: Nick Pope <[email protected]>
|
|
||
| Special type that includes only literal strings. A string | ||
| literal is compatible with ``LiteralString``, as is another | ||
| ``LiteralString``, but an object typed as just ``str`` is not. |
There was a problem hiding this comment.
@JelleZijlstra Can we also point out that composing literal strings is fine too?
A one-line example below might be useful too.
There was a problem hiding this comment.
I didn't follow the PEP closely -- how far does this go? I suppose "a" + "b" is good. What about "a" * 3? Or "a %s z" % "qqq"? Or ",".join(("x", "y", "z"))?
There was a problem hiding this comment.
All three are fine. Basically, if all the inputs (including self) are LiteralString, then the output type is a LiteralString. (We listed str operations that preserve the LiteralString type.)
There was a problem hiding this comment.
@pradeep90 any other feedback? Thanks for the review!
Lib/typing.py
Outdated
| ... | ||
|
|
||
| query("SELECT * FROM table") # ok | ||
| query(f"SELECT * FROM {input()}") # not ok |
There was a problem hiding this comment.
It may be worth including the + example here too. Otherwise, LGTM!
|
Planning to merge this once CI passes. |
https://bugs.python.org/issue47088