[3.7] bpo-47138: Ensure Windows docs build uses the same pinned version as other platforms (GH-32161) #32168
Conversation
…other platforms (pythonGH-32161) (cherry picked from commit 0dfabf9) Co-authored-by: Steve Dower <[email protected]>
|
@zooba: Status check is done, and it's a failure ❌ . |
|
@zooba: Status check is done, and it's a success ✅ . |
1 similar comment
|
@zooba: Status check is done, and it's a success ✅ . |
| @@ -13,7 +13,7 @@ if not defined SPHINXBUILD ( | |||
| %PYTHON% -c "import sphinx" > nul 2> nul | |||
| if errorlevel 1 ( | |||
| echo Installing sphinx with %PYTHON% | |||
| %PYTHON% -m pip install sphinx==2.2.0 | |||
| %PYTHON% -m pip install -r requirements.txt | |||
There was a problem hiding this comment.
The 3.7 branch does not have a requirements.txt for the Doc venv.
There was a problem hiding this comment.
Hah, I should've been checking that as I backported. Looks like it's a different fix for this version (and 3.8)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
(cherry picked from commit 0dfabf9)
Co-authored-by: Steve Dower [email protected]
https://bugs.python.org/issue47138