Skip to content

Updates PCBuild/readme.txt #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2017
Merged

Updates PCBuild/readme.txt #3418

merged 2 commits into from
Sep 8, 2017

Conversation

zooba
Copy link
Member

@zooba zooba commented Sep 7, 2017

Updates the PCBuild/readme.txt file for simpler install steps and new info.

@zooba zooba requested a review from zware September 7, 2017 03:33
zware
zware requested changes Sep 7, 2017
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things, otherwise looks good.

PCbuild/readme.txt Outdated
@@ -147,9 +135,13 @@ _msi
_multiprocessing
_overlapped
_socket
_testcapi
_sqlite3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is listed below.

PCbuild/readme.txt
@@ -15,29 +15,14 @@ Building Python using Microsoft Visual C++
This directory is used to build CPython for Microsoft Windows NT version
6.0 or higher (Windows Vista, Windows Server 2008, or later) on 32 and 64
bit platforms. Using this directory requires an installation of
Microsoft Visual C++ 2015 (MSVC 14.0) of any edition. The specific
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another mention of VS2015 on line 4.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@zooba
Copy link
Member Author

zooba commented Sep 7, 2017

I didn't expect the Spanish Inquisition!

@bedevere-bot
Copy link

Nobody expects the Spanish Inquisition!

@zware: please review the changes made to this pull request.

@zooba zooba merged commit bab21fa into python:master Sep 8, 2017
@zooba zooba deleted the update-readme branch September 8, 2017 03:10
@zware
Copy link
Member

zware commented Sep 8, 2017

I forgot to look at this again earlier, but the changes do look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware requested changes

Assignees
No one assigned
Labels
OS-windows skip issue skip news sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zooba @bedevere-bot @zware @Mariatta @the-knights-who-say-ni