bpo-31471: fix assertion failure in subprocess.Popen() on Windows, in case env has a bad keys() method #3580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
Sep 14, 2017
serhiy-storchaka
added
needs backport to 3.6
type-bug
|
Thanks @orenmn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 14, 2017
…ws, in case env has a bad keys() method. (pythonGH-3580) (cherry picked from commit 0b3a87e)
|
GH-3584 is a backport of this pull request to the 3.6 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Sep 14, 2017
serhiy-storchaka
pushed a commit
that referenced
this pull request
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_winapi.c: move the check whetherPyMapping_Keys()failed to right after calling it.test_subprocess.py: add a test to verify that the assertion failure is no more.https://bugs.python.org/issue31471