Skip to content

[2.7] bpo-31455: avoid calling "PyObject_GetAttrString()" with a live exception set #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2018
Merged

[2.7] bpo-31455: avoid calling "PyObject_GetAttrString()" with a live exception set #3992

merged 1 commit into from
Mar 24, 2018

Conversation

scoder
Copy link
Contributor

@scoder scoder commented Oct 14, 2017 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka dismissed their stale review October 14, 2017 07:54

Hmm, tests are failed.

@serhiy-storchaka
Copy link
Member

Do you mind to fix tests failure @scoder?

@serhiy-storchaka serhiy-storchaka changed the title bpo-31455: avoid calling "PyObject_GetAttrString()" with a live exception set [2.7] bpo-31455: avoid calling "PyObject_GetAttrString()" with a live exception set Feb 26, 2018
@scoder scoder closed this Feb 26, 2018
@scoder scoder reopened this Feb 26, 2018
@scoder
bpo-31544: Avoid calling "PyObject_GetAttrString()" (and potentially …
38fbd48 
…executing user code) with a live exception set.

Backport to Py2.7
@scoder
Copy link
Contributor Author

scoder commented Feb 26, 2018

Updated and rebased on latest 2.7 branch.
Took me a while to figure out what was wrong. In fact, pyET behaves entirely differently here and only looks up the methods at need, thus actually requiring them to be always available. Since that renders the test useless, I've disabled it for pyET and only left it in for cET.

@serhiy-storchaka serhiy-storchaka merged commit 0694b6a into python:2.7 Mar 24, 2018
@serhiy-storchaka
Copy link
Member

Thanks @scoder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scoder @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot