bpo-27200: fix faq/programming and datetime #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-buttu
commented
Mar 2, 2017
Doc/library/datetime.rst
Outdated
| .. doctest:: | ||
|
|
||
| >>> from datetime import datetime, timezone | ||
| >>> from tzinfo_examples import HOUR, Eastern |
There was a problem hiding this comment.
I have just added the two lines above, and deindented all the example of 1 whitespace, to fit the doctest directive indentation.
ezio-melotti
approved these changes
Mar 5, 2017
This was referenced Mar 10, 2017
berkerpeksag
approved these changes
Mar 18, 2017
|
Thanks! |
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Bumps [codecov](https://github.com/codecov/codecov-python) from 2.1.9 to 2.1.10. - [Release notes](https://github.com/codecov/codecov-python/releases) - [Changelog](https://github.com/codecov/codecov-python/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-python@v2.1.9...v2.1.10) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Mariatta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially fixes bpo-27200. Partially and not completely, because I followed the suggestion of @ezio-melotti to split the patch in several patches. This PR is the 2nd of the series, the first one was #240.
Here I changed the name of the file
tzinfo-examples.pytotzinfo_examples.py, for two reasons. The first one is the PEP8 conformity. The second one is thattzinfo-examplescould not be imported to execute the interactive example. It is not just a problem of doctest. The real problem is that the reader actually can not execute the example without renamingtzinfo-examplesin something else (without the-).