bpo-31802: Fix importing native path module before importing os. #4017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zware
requested changes
Jan 7, 2018
Lib/test/test_genericpath.py
Outdated
| @@ -486,6 +486,10 @@ def test_relpath_errors(self): | |||
| with self.assertRaisesRegex(TypeError, 'bytearray'): | |||
| self.pathmodule.relpath(bytearray(b'foo'), bytearray(b'bar')) | |||
|
|
|||
| def test_import(self): | |||
| support.script_helper.assert_python_ok( | |||
There was a problem hiding this comment.
support.script_helper needs to be imported.
|
When you're done making the requested changes, leave the comment: |
|
Thanks @zware! I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @zware: please review the changes made to this pull request. |
zware
approved these changes
Jan 7, 2018
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 7, 2018
…honGH-4017) (cherry picked from commit 3460198)
|
GH-5129 is a backport of this pull request to the 3.6 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31802