bpo-31947: names=None case is not handled by EnumMeta._create_ method #4288
Conversation
It seems to me that this method should not have `names=None` default value in signature, because that case is not handled, nor is it described as a possible value in the docstring. Seems like maybe a copy and paste from `__call__`, which has basically same signature, but `names=None` is valid and handled there. Or I humbly admit maybe there's something more going on that I'm not aware of. Anyway, I propose this small change.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
anentropic
changed the title
|
I have signed the CLA now |
serhiy-storchaka
changed the title
serhiy-storchaka
added
type-bug
|
@anentropic, sorry your CLA status did not get updated properly on our end. So now, I think the only holdup is a NEWS entry unless @ethanfurman thinks it does not need one. |
|
Attempting to figure out how to add a news entry... |
|
Thanks @anentropic for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-6484 is a backport of this pull request to the 3.7 branch. |
…onGH-4288) (cherry picked from commit b8e21f1) Co-authored-by: anentropic <[email protected]>
…onGH-4288) (cherry picked from commit b8e21f1) Co-authored-by: anentropic <[email protected]>
|
GH-6485 is a backport of this pull request to the 3.6 branch. |
) (cherry picked from commit b8e21f1) Co-authored-by: anentropic <[email protected]>
… (GH-6485) (cherry picked from commit b8e21f1) Co-authored-by: anentropic <[email protected]>
It seems to me that this method should not have
names=Nonedefault value in signature, because that case is not handled, nor is it described as a possible value in the docstring.Seems like maybe a copy and paste from
__call__, which has basically same signature, butnames=Noneis valid and handled there.Or I humbly admit maybe there's something more going on that I'm not aware of. Anyway, I propose this small change.
https://bugs.python.org/issue31947