bpo-24641: Improved error message for JSON unserializible keys. #4364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated an example for default() in the module docstring. Removed quotes around type name in other error messages.
serhiy-storchaka
force-pushed
the
json-serialize-errors
branch
from
add0ca2 to
3336a50
Compare
|
What are your thoughts @etrepum? Does this change look good to you? Will you accept porting it to simplejson (simplejson/simplejson#191)? |
|
Looks good to me for both here and simplejson. Would be good to get some test coverage to ensure that we're not missing something here in the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated an example for
default()in the module docstring.Removed quotes around type name in other error messages.
https://bugs.python.org/issue24641