Skip to content

bpo-32087: Set appropriate "translatable" attributes for nodes #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2018
Merged

bpo-32087: Set appropriate "translatable" attributes for nodes #4473

merged 3 commits into from
Feb 23, 2018

Conversation

cocoatomo
Copy link
Contributor

@cocoatomo cocoatomo commented Nov 20, 2017 •
edited by bedevere-bot
Loading

@cocoatomo
Copy link
Contributor Author

Could someone attach a label "skip news"?

@methane
Copy link
Member

methane commented Feb 22, 2018

I think translatable message shouldn't have fixed wording order.
Would you replace %s to {deprecated} and {removed}, and use .format(deprecated=self.arguments[0], removed=self.arguments[1]) instead of %?

@cocoatomo
Copy link
Contributor Author

Thank you for your comment.
I considered only the case of translating into Japanese.
For some languages, a reversed order of words may be natural.

I will change to use field name syntax.

@methane methane added skip news needs backport to 3.6 docs Documentation in the Doc dir labels Feb 23, 2018
@methane methane merged commit 0febc05 into python:master Feb 23, 2018
@miss-islington
Copy link
Contributor

Thanks @cocoatomo for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2018
@cocoatomo @miss-islington
bpo-32087: Doc: Make "deprecated-removed" directive translatable (pyt…
00697bd 
…honGH-4473)

(cherry picked from commit 0febc05)

Co-authored-by: cocoatomo <[email protected]>
@bedevere-bot
Copy link

GH-5828 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @cocoatomo and @methane, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0febc053736112d7bb9081742b3ac0ece7b973e7 2.7

@bedevere-bot
Copy link

GH-5829 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2018
@cocoatomo @miss-islington
bpo-32087: Doc: Make "deprecated-removed" directive translatable (pyt…
3a8fdd8 
…honGH-4473)

(cherry picked from commit 0febc05)

Co-authored-by: cocoatomo <[email protected]>
@methane
Copy link
Member

methane commented Feb 23, 2018

Python 2.7 doesn't have "deprecated-removed" directive.

@cocoatomo cocoatomo deleted the fix-issue-32087 branch February 23, 2018 11:58
miss-islington added a commit that referenced this pull request Feb 23, 2018
@miss-islington @cocoatomo
bpo-32087: Doc: Make "deprecated-removed" directive translatable (GH-…
c673a62 
…4473)

(cherry picked from commit 0febc05)

Co-authored-by: cocoatomo <[email protected]>
miss-islington added a commit that referenced this pull request Feb 23, 2018
@miss-islington @cocoatomo
bpo-32087: Doc: Make "deprecated-removed" directive translatable (GH-…
dd52d5c 
…4473)

(cherry picked from commit 0febc05)

Co-authored-by: cocoatomo <[email protected]>
@tk0miya tk0miya mentioned this pull request Feb 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cocoatomo @methane @miss-islington @bedevere-bot @the-knights-who-say-ni