Skip to content

bpo-32030: Add more options to _PyCoreConfig #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2017
Merged

bpo-32030: Add more options to _PyCoreConfig #4485

merged 1 commit into from
Nov 21, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 21, 2017 •
edited by bedevere-bot
Loading

Py_Main() now handles two more -X options:

  • -X showrefcount: new _PyCoreConfig.show_ref_count field
  • -X showalloccount: new _PyCoreConfig.show_alloc_count field

https://bugs.python.org/issue32030

@vstinner vstinner requested a review from a team November 21, 2017 01:32
@vstinner
bpo-32030: Add more options to _PyCoreConfig
2cab6ae 
Py_Main() now handles two more -X options:

* -X showrefcount: new _PyCoreConfig.show_ref_count field
* -X showalloccount: new _PyCoreConfig.show_alloc_count field
ncoghlan
ncoghlan approved these changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I love reviewing these PRs that incrementally flesh out the PEP 432 config structs with actual content. So much better than trying to ensure I covered everything in a separately maintained all-or-nothing branch :)

@vstinner vstinner merged commit 25420fe into python:master Nov 21, 2017
@vstinner vstinner deleted the pymain2 branch November 21, 2017 02:12
@vstinner
Copy link
Member Author

@ncoghlan: You're welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @ncoghlan @the-knights-who-say-ni @bedevere-bot