Improve Scheduler Objects documentation. #4556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention that the lower the priority number, the higher priority it represents.
Mariatta
added
needs backport to 3.6
skip issue
skip news
docs
|
Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 25, 2017
Mention that the lower the priority number, the higher priority it represents. (cherry picked from commit 9d5ec80)
|
GH-4557 is a backport of this pull request to the 3.6 branch. |
|
GH-4558 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 25, 2017
Mention that the lower the priority number, the higher priority it represents. (cherry picked from commit 9d5ec80)
Mariatta
pushed a commit
that referenced
this pull request
Nov 25, 2017
Mariatta
pushed a commit
that referenced
this pull request
Nov 25, 2017
| @@ -69,7 +69,7 @@ Scheduler Objects | |||
| Schedule a new event. The *time* argument should be a numeric type compatible | |||
| with the return value of the *timefunc* function passed to the constructor. | |||
| Events scheduled for the same *time* will be executed in the order of their | |||
| *priority*. | |||
| *priority*. A lower number represents a higher priority. | |||
There was a problem hiding this comment.
If the former wording was unclear, wouldn't be better to add just a word "increasing": executed in the order of increasing their *priority*. "Lower is higher" looks slightly orwellish to me.
There was a problem hiding this comment.
@serhiy-storchaka So we should invert the meaning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention that the lower the priority number, the higher priority it represents.