-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache #4641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a reasonable diff, lazycache should be added to all and the clearcache is improved by using clear().
The extra code changes are just semantics which help code readability without changing any functionality.
I've been signed for three times, but the state has not changed |
CLA status updated |
news entry added |
Misc/NEWS.d/next/Library/2017-12-04-10-14-23.bpo-32173.e0C5dF.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This issue is approved by 2 core developers, but was waiting on an update to the blurb. @ganziqim Please make the last changes requested by Mariatta, after which I believe this will be ready to merge. Thanks! |
d097431
to
4b004f7
Compare
done. |
https://bugs.python.org/issue32173