Skip to content

[2.7] bpo-10544: Deprecate "yield" in comprehensions and generator expressions in Py3k mode. (GH-4579) #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2017
Merged

[2.7] bpo-10544: Deprecate "yield" in comprehensions and generator expressions in Py3k mode. (GH-4579) #4676

merged 3 commits into from
Dec 2, 2017

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 2, 2017 •
edited by bedevere-bot
Loading

They will be deprecated in Python 3.7 and prohibited in Python 3.8.

https://bugs.python.org/issue10544

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Dec 2, 2017
@bedevere-bot bedevere-bot added the type-feature A feature request or enhancement label Dec 2, 2017
ncoghlan
ncoghlan approved these changes Dec 2, 2017
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just one request for an explanatory comment on the new list comp checking code.

Python/symtable.c Outdated
{
asdl_seq *generators = e->v.ListComp.generators;
int i;
int is_generator = st->st_cur->ste_generator;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the addition of is_generator on my first read-through of this function, so I think it could use an explanatory comment. Something like:

/* In order to check for yield expressions under '-3', we clear the generator flag, and restore it at the end */

@serhiy-storchaka serhiy-storchaka merged commit 65d1887 into python:2.7 Dec 2, 2017
@serhiy-storchaka serhiy-storchaka deleted the deprecate-yield-in-comprehensions-2.7 branch December 2, 2017 19:00
@serhiy-storchaka
Copy link
Member Author

Thanks @ncoghlan!

@mjpieters
Copy link
Contributor

This is on the 2.7 branch, not the 3.7 branch. In 3.7b1 this is currently not a deprecation warning. Wrong branch perhaps?

@serhiy-storchaka
Copy link
Member Author

See #4579 for 3.7 and #4676 for 3.8.

@mjpieters
Copy link
Contributor

Excellent, thanks! I was confused because I missed that 3.7 was still the master branch when the first commit went in, the separate 3.7 branch had yet to be cut.

See #4579 for 3.7 and #4676 for 3.8.

<mode demeanor="pedant">#4676 is this PR :-) The 3.8 SyntaxError change is #4564.</mode>

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @mjpieters @ncoghlan @the-knights-who-say-ni @bedevere-bot