bpo-29645: Speed up importing the webbrowser module. #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbrowser.register() is now thread-safe.
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @eric-s-raymond, @freddrake, @rhettinger, @birkenfeld and @tim-one to be potential reviewers. |
|
Tests were failed because |
ncoghlan
approved these changes
Mar 8, 2017
|
Note that the effects of the register_standard_browser call in register() are blocked by the lock. try_order will eventually get flushed out with the get/open() call, but the pre-registered browser will always be at the start of the list, instead of respecting 'preferred'. |
|
Is there something wrong with the code? Please open an issue on the bag tracker. |
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Update runtime to the latest Python3.9 release * Update runtime.txt Co-authored-by: Mariatta Wijaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webbrowser.register() is now thread-safe.