Skip to content

bpo-32360: Remove object_pairs_hook=OrderedDict examples #5001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2018
Merged

bpo-32360: Remove object_pairs_hook=OrderedDict examples #5001

merged 5 commits into from
Apr 3, 2018

Conversation

methane
Copy link
Member

@methane methane commented Dec 24, 2017 •
edited
Loading

Remove OrederedDict from document (including docstring) and json.tool.

https://bugs.python.org/issue32360

@methane methane requested a review from rhettinger December 25, 2017 17:24
@methane methane requested review from rhettinger and removed request for rhettinger January 18, 2018 09:43
@methane
Copy link
Member Author

methane commented Jan 18, 2018

@rhettinger Would you review this?
This is almost doc update; current doc suggests using OrderedDict for object_pairs_hook
which doesn't make sense from Python 3.7.

@methane methane mentioned this pull request Jan 25, 2018
Merged
@methane methane force-pushed the remove-odict-jsontool branch from 12ba04f to 9ec9ac3 Compare January 25, 2018 10:54
@methane methane changed the title bpo-32360: Remove OrderedDict from json bpo-32360: doc: Remove object_pairs_hook=OrderedDict idiom Jan 25, 2018
@methane methane added the docs Documentation in the Doc dir label Jan 25, 2018
@methane methane mentioned this pull request Mar 25, 2018
Merged
@methane methane changed the title bpo-32360: doc: Remove object_pairs_hook=OrderedDict idiom bpo-32360: doc: Remove object_pairs_hook=OrderedDict Apr 3, 2018
@methane methane changed the title bpo-32360: doc: Remove object_pairs_hook=OrderedDict bpo-32360: Remove object_pairs_hook=OrderedDict examples Apr 3, 2018
@methane methane merged commit 629338f into python:master Apr 3, 2018
@methane methane deleted the remove-odict-jsontool branch April 3, 2018 03:39
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@python python deleted a comment from miss-islington Apr 3, 2018
@python python deleted a comment from miss-islington Apr 3, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2018
@methane @miss-islington
bpo-32360: Remove object_pairs_hook=OrderedDict examples (pythonGH-5001)
fec7098 
(cherry picked from commit 629338f)

Co-authored-by: INADA Naoki <[email protected]>
@bedevere-bot
Copy link

GH-6361 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Apr 3, 2018
@miss-islington @methane
bpo-32360: Remove object_pairs_hook=OrderedDict examples (GH-5001)
0c53357 
(cherry picked from commit 629338f)

Co-authored-by: INADA Naoki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @miss-islington @bedevere-bot @the-knights-who-say-ni