bpo-26915: Test identity first in membership operation #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhangyangyu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhettinger, @benjaminp, @1st1, @tiran and @ezio-melotti to be potential reviewers. |
serhiy-storchaka
requested review from
rhettinger
and removed request for
serhiy-storchaka
|
The code LGTM, but I have no opinion about this issue. |
methane
approved these changes
Mar 7, 2017
Lib/test/test_collections.py
Outdated
| ItemsView({1: nan, 2: obj}), | ||
| ValuesView({1: nan, 2: obj}) | ||
| ] | ||
| for container in containers: | ||
| for elem in container: | ||
| self.assertIn(elem, container) | ||
| self.assertEqual(seq.index(nan), 0) | ||
| self.assertNotEqual(seq.index(nan), 1) |
There was a problem hiding this comment.
This assertNotEqual seems redundant.
zhangyangyu
added a commit
to zhangyangyu/cpython
that referenced
this pull request
Mar 8, 2017
… count() methods of collections.abc.Sequence (pythonGH-503)
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Bumps [cachetools](https://github.com/tkem/cachetools) from 4.2.4 to 5.0.0. - [Release notes](https://github.com/tkem/cachetools/releases) - [Changelog](https://github.com/tkem/cachetools/blob/master/CHANGELOG.rst) - [Commits](tkem/cachetools@v4.2.4...v5.0.0) --- updated-dependencies: - dependency-name: cachetools dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mariatta Wijaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.