bpo-32374: Document that m_traverse for multi-phase initialized modules can be called with m_state=NULL #5140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2018 17:14
|
Anything I can do to help move this forward? |
|
Commenting and tagging me worked :) |
|
Thanks @Traceur759 for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-6128 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2018
Multi-phase initialized modules allow m_traverse to be called while the module is still being initialized, so module authors may need to account for that. (cherry picked from commit c2b0b12) Co-authored-by: Marcel Plch <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2018
Multi-phase initialized modules allow m_traverse to be called while the module is still being initialized, so module authors may need to account for that. (cherry picked from commit c2b0b12) Co-authored-by: Marcel Plch <[email protected]>
|
GH-6129 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 17, 2018
Multi-phase initialized modules allow m_traverse to be called while the module is still being initialized, so module authors may need to account for that. (cherry picked from commit c2b0b12) Co-authored-by: Marcel Plch <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 17, 2018
Multi-phase initialized modules allow m_traverse to be called while the module is still being initialized, so module authors may need to account for that. (cherry picked from commit c2b0b12) Co-authored-by: Marcel Plch <[email protected]>
jo2y
pushed a commit
to jo2y/cpython
that referenced
this pull request
Mar 23, 2018
Multi-phase initialized modules allow m_traverse to be called while the module is still being initialized, so module authors may need to account for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides documentation on correct handling of multiphase initialized modules' traversing.
It also contains a check that, in a debug build (--with-pydebug), does a sanity check for m_traverse handling the m_state==NULL case early.
https://bugs.python.org/issue32374