bpo-29736: Optimize builtin types constructor #519
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace PyArg_ParseTupleAndKeywords() with _PyArg_ParseTupleAndKeywordsFast() to optimize the constructor of the builtin types: * bool: bool_new() * bytes: bytes_new() * complex: complex_new() * float: float_new() * int: long_new() * list: list_init() * str: unicode_new() * tuple: tuple_new()
|
I don't really like moving the parse string outside of the call to the parser. We have a long history of keeping these together. To me it like having a printf_fast(&formatter, a, b, c); The format and the arguments are tightly coupled, so separating them makes the code harder to work with. This isn't just optimization, it is design of a new C-API that is very different from what came before. |
|
This old PR now has many conflicts and I lost interest in this PR, so I close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace PyArg_ParseTupleAndKeywords() with
_PyArg_ParseTupleAndKeywordsFast() to optimize the constructor of the
builtin types:
http://bugs.python.org/issue29736