Skip to content

bpo-32634: fix write in email/generator.py #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

reb00ter
Copy link

@reb00ter reb00ter commented Jan 22, 2018

add_header when email dont have it

https://bugs.python.org/issue32634

add_header when email dont have it
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@reb00ter reb00ter changed the title Update generator.py bpo-3264: fix write in email/generator.py Jan 23, 2018
@reb00ter reb00ter changed the title bpo-3264: fix write in email/generator.py bpo-32634: fix write in email/generator.py Jan 23, 2018
@matrixise
Copy link
Member

Hi @reb00ter

Thank you for your contribution, it's great.

But for my part, I have few points.

  1. there is no new tests with your fix
  2. you have cleaned the code but it's not needed maybe you could just submit your fix and not the cleaning.

@bitdancer and @warsaw are the experts for the email part and I would like to have their opinion.

Thank you

@bitdancer
Copy link
Member

Thanks for your work, but there is an existing PR for this almost ready to go (#1977). Also, FYI the style changes would have been rejected.

@bitdancer bitdancer closed this Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants