Skip to content

Exclude myself from mention-bot #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Exclude myself from mention-bot #529

merged 1 commit into from
Mar 7, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 7, 2017

I made changes in almost all CPython files last 5 years, so
mention-bot asks me to review basically all pull requests. I simply
don't have the bandwidth to review everything, sorry! I prefer to
select myself which PR I want to follow.

@mention-bot
Copy link

@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dstufft and @Carreau to be potential reviewers.

@vstinner
Copy link
Member Author

vstinner commented Mar 7, 2017

I'm not sure if I should put my name in userBlacklist or userBlacklistForPR.

@vstinner
Copy link
Member Author

vstinner commented Mar 7, 2017

I'm not sure if I should put my name in userBlacklist or userBlacklistForPR.

I will follow Stefan Krah's example: put my GitHub login in both lists ;-)

@Carreau
Copy link
Contributor

Carreau commented Mar 7, 2017

While you are at it can you add .mentionbot to the list of ignored files ?

@dstufft
Copy link
Member

dstufft commented Mar 7, 2017

@Haypo You want to add yourself to userBlacklist.

@dstufft
Copy link
Member

dstufft commented Mar 7, 2017

userBlacklistForPR will stop the mention bot from mentioning anyone on your PRs.

I made changes in almost all CPython files last 5 years, so
mention-bot asks me to review basically all pull requests. I simply
don't have the bandwidth to review everything, sorry! I prefer to
select myself which PR I want to follow.
@vstinner
Copy link
Member Author

vstinner commented Mar 7, 2017

@Carreau: "While you are at it can you add .mentionbot to the list of ignored files ?"

I don't see .mentionbot in "git status". What is your OS? What is the issue? :-)

@vstinner
Copy link
Member Author

vstinner commented Mar 7, 2017

@dstufft : "You want to add yourself to userBlacklist."

Oh ok, done :-)

@dstufft
Copy link
Member

dstufft commented Mar 7, 2017

@Haypo he means to add .mention-bot to the list of blacklisted files inside of the .mention-bot file. I wouldn't do that though, I think it's useful ¯\_(ツ)_/¯

@vstinner
Copy link
Member Author

vstinner commented Mar 7, 2017

"@Haypo he means to add .mention-bot to the list of blacklisted files inside of the .mention-bot file. I wouldn't do that though, I think it's useful ¯_(ツ)_/¯"

Ah, please propose a PR for that @Carreau. At least, I will no more be be impacted once this change will be merged :-D

@Carreau
Copy link
Contributor

Carreau commented Mar 7, 2017

Ah, please propose a PR for that @Carreau. At least, I will no more be be impacted once this change will be merged :-D

Understood, I'll make a PR and ping you manually everywhere, just to be sure you don't miss anything.

@AraHaan
Copy link
Contributor

AraHaan commented Mar 7, 2017

heh, nice way to pick on him. 😛

@vstinner vstinner merged commit fea9676 into python:master Mar 7, 2017
@vstinner
Copy link
Member Author

vstinner commented Mar 7, 2017

"Understood, I'll make a PR and ping you manually everywhere, just to be sure you don't miss anything."

Thanks! :-)

@vstinner vstinner deleted the mention_bot branch June 15, 2017 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants