Skip to content

bpo-10381: Cleanup dangling reference in get_timezone_utc_capi #5317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2018
Merged

bpo-10381: Cleanup dangling reference in get_timezone_utc_capi #5317

merged 1 commit into from
Jan 25, 2018

Conversation

pganssle
Copy link
Member

@pganssle pganssle commented Jan 25, 2018 •
edited
Loading

Per @vstinner's comment, the C API test was erroneously not increasing the refcount on the UTC singleton.

This is a bugfix to unreleased changes, so news is unnecessary.

https://bugs.python.org/issue10381

vstinner
vstinner approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

"./python -m test -R 3:3 test_datetime" succeed: not only it doesn't crash anymore, but the _datetime module doesn't leak references ;-)

@vstinner vstinner merged commit 58dc03c into python:master Jan 25, 2018
@pganssle pganssle mentioned this pull request Jan 25, 2018
Merged
@pganssle pganssle deleted the fix_dangling_ref branch October 25, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pganssle @vstinner @the-knights-who-say-ni @bedevere-bot