bpo-20185: Convert the marshal module to Argument Clinic. #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on patch by Vajrasky Kok.
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kristjanvalur, @vsajip, @benjaminp, @tim-one and @Yhg1s to be potential reviewers. |
methane
reviewed
Mar 7, 2017
Python/marshal.c
Outdated
|
|
||
| Return the string that would be written to a file by dump(value, file). |
There was a problem hiding this comment.
Maybe, 'string' should be 'bytes' in Python 3.
But it's unrelated to this pull request, because old docstring says it 'string' too.
There was a problem hiding this comment.
Ah, that is why I still have not pushed this patch! I noticed this when wrote the patch but forgot to open separate issue. Now it is opened: bpo-29746.
methane
approved these changes
Mar 7, 2017
|
Looks okay to me |
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Bumps [celery](https://github.com/celery/celery) from 5.2.3 to 5.2.6. - [Release notes](https://github.com/celery/celery/releases) - [Changelog](https://github.com/celery/celery/blob/v5.2.6/Changelog.rst) - [Commits](celery/celery@v5.2.3...v5.2.6) --- updated-dependencies: - dependency-name: celery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mariatta Wijaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on patch by Vajrasky Kok.