Skip to content

bpo-32647: Link ctypes extension with libdl. #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2018

Conversation

tiran
Copy link
Member

@tiran tiran commented Feb 5, 2018

The ctypes module used to depend on indirect linking for dlopen. The shared
extension is now explicitly linked against libdl on platforms with dl.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue32647

The ctypes module used to depend on indirect linking for dlopen. The shared
extension is now explicitly linked against libdl on platforms with dl.

Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran force-pushed the bpo32647-ctypes-dl branch from 8b4aff0 to 10162d3 Compare February 22, 2018 16:04
@tiran tiran merged commit 5bb9692 into python:master Feb 25, 2018
@bedevere-bot
Copy link

@tiran: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@tiran tiran deleted the bpo32647-ctypes-dl branch February 25, 2018 09:22
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 25, 2018
The ctypes module used to depend on indirect linking for dlopen. The shared
extension is now explicitly linked against libdl on platforms with dl.

Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 5bb9692)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-5874 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-5875 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 25, 2018
The ctypes module used to depend on indirect linking for dlopen. The shared
extension is now explicitly linked against libdl on platforms with dl.

Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 5bb9692)

Co-authored-by: Christian Heimes <[email protected]>
@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5bb9692575f10f4a7c7f1c2c0c70956baf6d5c23 2.7

tiran added a commit to tiran/cpython that referenced this pull request Feb 25, 2018
The ctypes module used to depend on indirect linking for dlopen. The shared
extension is now explicitly linked against libdl on platforms with dl.

Signed-off-by: Christian Heimes <[email protected]>.
(cherry picked from commit 5bb9692)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-5877 is a backport of this pull request to the 2.7 branch.

tiran added a commit that referenced this pull request Feb 25, 2018
The ctypes module used to depend on indirect linking for dlopen. The shared
extension is now explicitly linked against libdl on platforms with dl.

Signed-off-by: Christian Heimes <[email protected]>.
(cherry picked from commit 5bb9692)

Co-authored-by: Christian Heimes <[email protected]>
tiran added a commit that referenced this pull request Feb 25, 2018
The ctypes module used to depend on indirect linking for dlopen. The shared
extension is now explicitly linked against libdl on platforms with dl.

Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 5bb9692)

Co-authored-by: Christian Heimes <[email protected]>
tiran added a commit that referenced this pull request Feb 25, 2018
The ctypes module used to depend on indirect linking for dlopen. The shared
extension is now explicitly linked against libdl on platforms with dl.

Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 5bb9692)

Co-authored-by: Christian Heimes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants