-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-32820: __format__ method for ipaddress #5627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
45ea3c6
bits method and test_bits
ewosborne b470a10
Cleaned up assert string
ewosborne 4c8af71
blurb
ewosborne d1f9732
added docstring
ewosborne b72330d
Faster method, per Eric Smith
ewosborne 6c7d1a4
redoing as __format__
ewosborne 6a1d467
added ipv6 method
ewosborne 41f637a
test cases and cleanup
ewosborne eddcc39
updated news
ewosborne eabf6d9
cleanup and NEWS.d
ewosborne ba05386
cleaned up old NEWS
ewosborne 2bd9f60
removed cut and paste leftover
ewosborne d865609
one more cleanup
ewosborne 798af6e
moved to regexp, moved away from v4- and v6-specific versions of __fo…
ewosborne db383e1
More cleanup, added ipv6 test cases
ewosborne b433282
more cleanup
ewosborne 41109cc
more cleanup
ewosborne 861b5e4
cleanup
ewosborne 398b2c7
cleanup
ewosborne 0274c0f
cleanup per review, part 1
ewosborne 6d5fbdb
addressed review comments around help string and regexp matching
ewosborne d9061d2
wrapped v6 test strings. contiguous integers: break at 72char. with u…
ewosborne 1401142
's' and '' tests for pv4 and ipv6
ewosborne acc1f06
whitespace cleanup
ewosborne 8354756
Remove trailing whitespace
zware aaaa45c
Remove more trailing whitespace
zware 8e1d9ca
Remove an excess blank line
zware File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Library/2018-02-13-12-25-43.bpo-32820.0stF0u.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Added __format__ to IPv4 and IPv6 classes. Always outputs a fully zero- | ||
padded string. Supports b/x/n modifiers (bin/hex/native format). Native | ||
format for IPv4 is bin, native format for IPv6 is hex. Also supports '#' and | ||
'_' modifiers. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.