-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-32898: Fix debug build crash with COUNT_ALLOCS #5800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Signed CLA. It should be ready within a couple of hours? |
Yes, it should be ready within a couple of hours. Please add your name in Misc/ACKS and add a news entry (you can use the blurb utility as described in the developer guide). |
Ready! |
Thanks @eduardo-elizondo for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
) (cherry picked from commit 745dc65) Co-authored-by: Eddie Elizondo <[email protected]>
GH-5806 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 745dc65) Co-authored-by: Eddie Elizondo <[email protected]>
The following build crashed:
mkdir debug && cd debug
../configure --with-pydebug
make EXTRA_CFLAGS="-DCOUNT_ALLOCS"
The bug was introduced in: 25420fe
Fix:
https://bugs.python.org/issue32898