-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
controlflow: Use full example for "5 through 9" #5907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace example result of "5 through 9" with complete list: "5, 6, 7, 8, 9". This format is more consistent with the surrounding examples.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
@the-knights-who-say-ni Acknowledged. I have now filled out and signed the contributor agreement. |
Thanks @Stevoisiak for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
Thanks @Stevoisiak and congrats on your first contribution to CPython 🌮 |
Replace example result of "5 through 9" with complete list: "5, 6, 7, 8, 9". This format is more consistent with the surrounding examples. (cherry picked from commit 83d7062) Co-authored-by: Steven M. Vascellaro <[email protected]>
GH-6039 is a backport of this pull request to the 3.7 branch. |
Sorry, @Stevoisiak and @Mariatta, I could not cleanly backport this to |
Replace example result of "5 through 9" with complete list: "5, 6, 7, 8, 9". This format is more consistent with the surrounding examples. (cherry picked from commit 83d7062) Co-authored-by: Steven M. Vascellaro <[email protected]>
GH-6040 is a backport of this pull request to the 3.6 branch. |
Replace example result of "5 through 9" with complete list: "5, 6, 7, 8, 9". This format is more consistent with the surrounding examples. (cherry picked from commit 83d7062) Co-authored-by: Steven M. Vascellaro <[email protected]>
Thanks @Stevoisiak for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-6066 is a backport of this pull request to the 3.7 branch. |
Replace example result of "5 through 9" with complete list: "5, 6, 7, 8, 9". This format is more consistent with the surrounding examples. (cherry picked from commit 83d7062) Co-authored-by: Steven M. Vascellaro <[email protected]>
Replace example result of "5 through 9" with complete list: "5, 6, 7, 8, 9". This format is more consistent with the surrounding examples. (cherry picked from commit 83d7062) Co-authored-by: Steven M. Vascellaro <[email protected]>
Replace example result of "5 through 9" with complete list: "5, 6, 7, 8, 9". This format is more consistent with the surrounding examples.
Do you mind to create a backport to 2.7 @Stevoisiak? |
@serhiy-storchaka How would I go about creating a backport? Would I just recreate the commit for the 2.7 branch? |
Yes, just recreate the commit for the 2.7 branch. You can manually create a new branch from 2.7, |
@serhiy-storchaka I'm having some issues with my Git client that prevent me from backporting this myself. |
The doc for 2.7 is correct, so we don't need to backport.
|
Minor wording change to replace example output "5 through 9" with "5, 6, 7, 8, 9".
This format is more consistent with the surrounding examples.