bpo-32960: dataclasses disallow frozen inheritance #5919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n classes, and also disallow inheriting non-frozen from frozen classes. This restriction will be relaxed at a future date.
|
Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
ericvsmith
deleted the
bpo-32960-dataclasses-disallow-frozen-inheritance
branch
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2018
…n classes and vice-versa, (pythonGH-5919) This restriction will be relaxed at a future date. (cherry picked from commit 2fa6b9e) Co-authored-by: Eric V. Smith <[email protected]>
|
GH-5920 is a backport of this pull request to the 3.7 branch. |
ericvsmith
added a commit
that referenced
this pull request
Feb 27, 2018
…n classes and vice-versa, (GH-5919) (GH-5920) This restriction will be relaxed at a future date. (cherry picked from commit 2fa6b9e) Co-authored-by: Eric V. Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow inheriting frozen from non-frozen and non-frozen from frozen.
https://bugs.python.org/issue32960