bpo-32989: IDLE - fix bad editor call of pyparse method #5968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
changed the title
terryjreedy
changed the title
terryjreedy
changed the title
terryjreedy
changed the title
|
I removed the " needs backport to 3.6" label, the 3.6 branch no long accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
terryjreedy
changed the title
|
I have reviewed and tweaked everything except the new indent tests, including the proposed commit message. Correct calls to find...start should work since they presumably did before the parameter was removed, but I want to check a bit more. Edit: After merging master, I discovered that the call change was already done on another issue. The there should not be any behavior change with remaining patch. |
terryjreedy
approved these changes
Jan 21, 2020
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2020
Fix comments and add tests for editor newline_and_indent_event method. Remove unused None default for function parameter of pyparse find_good_parse_start method and code triggered by that default. Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit ec64640) Co-authored-by: Cheryl Sabella <[email protected]>
|
GH-18096 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2020
Fix comments and add tests for editor newline_and_indent_event method. Remove unused None default for function parameter of pyparse find_good_parse_start method and code triggered by that default. Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit ec64640) Co-authored-by: Cheryl Sabella <[email protected]>
|
GH-18097 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 21, 2020
Fix comments and add tests for editor newline_and_indent_event method. Remove unused None default for function parameter of pyparse find_good_parse_start method and code triggered by that default. Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit ec64640) Co-authored-by: Cheryl Sabella <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jan 21, 2020
Fix comments and add tests for editor newline_and_indent_event method. Remove unused None default for function parameter of pyparse find_good_parse_start method and code triggered by that default. Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit ec64640) Co-authored-by: Cheryl Sabella <[email protected]>
|
Thanks, Terry! |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Fix comments and add tests for editor newline_and_indent_event method. Remove unused None default for function parameter of pyparse find_good_parse_start method and code triggered by that default. Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix comments and add tests for editor newline_and_indent_event method.
Remove unused None default for function parameter of pyparse find_good_parse_start method
and code triggered by that default.
https://bugs.python.org/issue32989