bpo-32517: fix test_read_pty_output() hangs on macOS 10.13.2+ #6037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
test_asyncio hangs indefinitely on macOS 10.13.2+ on `read_pty_output()` using the KqueueSelector. Closing `proto.transport` (as is done in `write_pty_output()`) seems to fix it.
n8henrie
force-pushed
the
fix-issue-32517
branch
from
6e8c000 to
cd38fa5
Compare
1st1
approved these changes
Mar 9, 2018
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 9, 2018
…GH-6037) test_asyncio hangs indefinitely on macOS 10.13.2+ on `read_pty_output()` using the KqueueSelector. Closing `proto.transport` (as is done in `write_pty_output()`) seems to fix it. (cherry picked from commit 12f74d8) Co-authored-by: Nathan Henrie <[email protected]>
|
GH-6038 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @n8henrie and @1st1, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Mar 9, 2018
test_asyncio hangs indefinitely on macOS 10.13.2+ on `read_pty_output()` using the KqueueSelector. Closing `proto.transport` (as is done in `write_pty_output()`) seems to fix it. (cherry picked from commit 12f74d8) Co-authored-by: Nathan Henrie <[email protected]>
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Mar 14, 2018
…GH-6037) test_asyncio hangs indefinitely on macOS 10.13.2+ on `read_pty_output()` using the KqueueSelector. Closing `proto.transport` (as is done in `write_pty_output()`) seems to fix it. (cherry picked from commit 12f74d8) Co-authored-by: Nathan Henrie <[email protected]> Also, re-enable test_read_pty_output on macOS.
ned-deily
added a commit
that referenced
this pull request
Mar 27, 2018
… (GH-6113) test_asyncio hangs indefinitely on macOS 10.13.2+ on `read_pty_output()` using the KqueueSelector. Closing `proto.transport` (as is done in `write_pty_output()`) seems to fix it. (cherry picked from commit 12f74d8) Co-authored-by: Nathan Henrie <[email protected]> Also, re-enable test_read_pty_output on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_asyncio hangs indefinitely on macOS 10.13.2+ on
read_pty_output()using the KqueueSelector. Closing
proto.transport(as is done inwrite_pty_output()) seems to fix it.https://bugs.python.org/issue32517