Skip to content

bpo-29741: make some BytesIO methods accept integer types (only changes in Modules/_io) #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2017
Merged

bpo-29741: make some BytesIO methods accept integer types (only changes in Modules/_io) #606

merged 3 commits into from
Mar 10, 2017

Conversation

orenmn
Copy link
Contributor

@orenmn orenmn commented Mar 10, 2017

according to http://bugs.python.org/issue29741:

  • change some functions in Modules/_io/stringio.c and in Modules/_io/bytesio.c to use _PyIO_ConvertSsize_t (which accepts integer types)
  • change _io_BytesIO_truncate_impl so that it would accept integer types

(I ran the test module again on my Ubuntu 16.04 VM, and none of the tests failed.)

@mention-bot
Copy link

@orenmn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @avassalotti, @benjaminp, @loewis and @vadmium to be potential reviewers.

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 10, 2017
@serhiy-storchaka serhiy-storchaka merged commit 7400254 into python:master Mar 10, 2017
orenmn added a commit to orenmn/cpython that referenced this pull request Mar 13, 2017
@orenmn
commit changes from PR python#650 and python#606
4beafeb
@orenmn orenmn mentioned this pull request Mar 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orenmn @mention-bot @serhiy-storchaka @the-knights-who-say-ni