Skip to content

bpo-33064: lib2to3: Add more tests #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2018
Merged

bpo-33064: lib2to3: Add more tests #6101

merged 1 commit into from
Mar 13, 2018

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Mar 13, 2018 •
edited by bedevere-bot
Loading

@ambv ambv requested a review from serhiy-storchaka March 13, 2018 09:05
@ambv ambv mentioned this pull request Mar 13, 2018
Merged
serhiy-storchaka
serhiy-storchaka reviewed Mar 13, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all is in TestFunctionAnnotations, so it is worth to add annotations.

And since a different grammar rule is used for a parameter list in lambdas, we need to duplicate all these tests with lambdas but without annotations in a separate class.

@ambv ambv force-pushed the lib2to3-moretests branch from 8fcbd66 to 5d0d945 Compare March 13, 2018 16:48
@ambv
Copy link
Contributor Author

ambv commented Mar 13, 2018

Serhiy, I added all your requested changes.

serhiy-storchaka
serhiy-storchaka approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ambv ambv merged commit 74f5687 into python:master Mar 13, 2018
@miss-islington
Copy link
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2018
@ambv @miss-islington
lib2to3: Add more tests (pythonGH-6101)
c3f1fe0 
(cherry picked from commit 74f5687)

Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-bot
Copy link

GH-6108 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2018
@ambv @miss-islington
lib2to3: Add more tests (pythonGH-6101)
589d6cc 
(cherry picked from commit 74f5687)

Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-bot
Copy link

GH-6109 is a backport of this pull request to the 3.6 branch.

ambv added a commit that referenced this pull request Mar 13, 2018
@miss-islington @ambv
lib2to3: Add more tests (GH-6101) (#6108)
7d0528d 
(cherry picked from commit 74f5687)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Mar 13, 2018
@miss-islington @ambv
lib2to3: Add more tests (GH-6101) (#6109)
cad3eb2 
(cherry picked from commit 74f5687)

Co-authored-by: Łukasz Langa <[email protected]>
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@ambv @jo2y
lib2to3: Add more tests (python#6101)
596db1c
@ambv ambv deleted the lib2to3-moretests branch July 12, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ambv @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni