Skip to content

bpo-33083 - math.factorial accepts non-integral Decimal instances #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 3, 2018
Merged

bpo-33083 - math.factorial accepts non-integral Decimal instances #6149

merged 6 commits into from
Sep 3, 2018

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 19, 2018 •
edited by bedevere-bot
Loading

@pablogsal pablogsal changed the title bpo33083 - math.factorial accepts non-integral Decimal instances bpo-33083 - math.factorial accepts non-integral Decimal instances Mar 19, 2018
DylanMeeus
DylanMeeus reviewed Apr 16, 2018
View reviewed changes
Misc/NEWS.d/next/Core and Builtins/2018-03-19-00-59-20.bpo-33083.Htztjl.rst Outdated
@@ -0,0 +1,3 @@
math.factorial no longer accept arguments that are not int-like. A
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for nit-picking a bit. But

"math.factorial no longer accepts arguments.." (accept -> accepts).

emmited -> emitted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

taleinat
taleinat requested changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was decided on the issue to avoid deprecating floats as part of this issue. Please undo the changes regarding deprecation of floats; though perhaps keep them stashed somewhere for future use...

Modules/mathmodule.c Outdated
}
else{
pyint_form = PyNumber_Index(arg);
if( pyint_form == NULL){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the spacing on this and the next line.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

taleinat
taleinat requested changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NEWS entry no longer correctly reflects the changes made; please revise.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!

@pablogsal
Copy link
Member Author

I have made the requested changes; please review again. Thank you for the whitespace fix!

@bedevere-bot
Copy link

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

@pablogsal pablogsal force-pushed the bpo33083 branch 2 times, most recently from a449b46 to 4b465a4 Compare July 30, 2018 19:16
taleinat
taleinat approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdickinson
mdickinson approved these changes Jul 31, 2018
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vstinner
vstinner reviewed Jul 31, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can merge it @pablogsal ;-)

vstinner
vstinner approved these changes Jul 31, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @pablogsal you can merge it.

vstinner
vstinner approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal pablogsal merged commit e9ba370 into python:master Sep 3, 2018
@pablogsal pablogsal deleted the bpo33083 branch September 3, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanMeeus DylanMeeus DylanMeeus left review comments

@vstinner vstinner vstinner approved these changes

@taleinat taleinat taleinat approved these changes

@mdickinson mdickinson mdickinson approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pablogsal @bedevere-bot @vstinner @taleinat @mdickinson @DylanMeeus @serhiy-storchaka @the-knights-who-say-ni